Skip to content

Minor fix of contour WM for visualization #721

@jan-petr

Description

@jan-petr

Description

  • The DataParTemplate.m needs to have a clearer description 👍
  • The contour visualization function should not be inside the wrapper but in a function. Adding it as option to xASL_vis_CreateVisualFig would be best (So the most transparent way is to add the contour option to the function, and in the wrapper state in which cases we want this option (i.e. the booleans you created). Instead, you added all functionality to the wrapper ;) So the solution is to move the contour creation etc to the function, and keep the booleans (i.e. the ExploreASL wrapping part) in the wrapper, don't you agree?) 👍
  • xASL_delete already checks for if exist, including gz support, so this can be shortened (by removing the if exist() part 👍 (yes, but couldn't find this, probably was fixed already)
  • pGMC is a bit unclear, would replace by pGM_contour 👍

Release notes

Additional fixing to #182

Metadata

Metadata

Assignees

Labels

optimizationEnsure that code runs faster with unchanged functionality

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions