Skip to content

Revamp x structure fields of import & processing #717

@HenkMutsaerts

Description

@HenkMutsaerts

Description

  • x.opts contains general parameters for initialization or running ExploreASL, not specific to import or processing

  • x.settings contains settings specific to the processing (should not be used in import) Does it help to rename this to x.Processing or should these go to x.modules.processing.settings?

  • x.S (statistics) should be initialized when starting the processing (begin of ExploreASL_ProcessMaster)

  • x.Q (quantification) should be initialized when starting the processing (begin of ExploreASL_ProcessMaster)

  • x.P (processing paths of the dataset) should be initialized when starting the processing (begin of ExploreASL_ProcessMaster)

  • x.dataset should not be initialized when only initialising ExploreASL? Also, this should probably go under x.opts.

  • x.dir should be a subtract of x.opts to clarify that these directories are general (non-import/processing specific)

  • x.MyPath should go under x.opts as this is a general option

  • x.subject_regexp, x.Quality`` and x.DELETETEMPare specific to processing, so should go tox.module.process` and should not exist before data loading & processing

  • x.name this is the same as x.dataset and can be removed I think

  • x.nSubjects x.nSessions etc should go under x.module.process

  • x.SESSIONS can go to x.module.process.SESSIONS, same for x.SUBJECTS but perhaps better to wait with this as this would be a huge change

Release notes

The ExploreASL x struct and with that some of the ExploreASL settings were moved to dedicated fields. For backwards compatibility a table was created and automated workflows were implemented.

Metadata

Metadata

Labels

featureNew feature, enhancement or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions