-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Description
Description
Various bugs are uncovered and fixed while running the full scale testing of import/processing/UT - this is the second part of the task with errors not really in code, but in the testing data and scripts. This can be corrected later as it won't affect normal ExploreASL execution by the users.
Tasks
- Unzip Population/Template_6.nii before running segmentation in
Philips_2DEPI_Segmentation_2D_T2_SPM_HiQ - M0 Incorrectly changed from UseControlAsM0 -> Absent for Bsup == ON. This is incorrect, as also for this flavor, we can compensate for BSup and run M0 quantification. Includes these flavors:
Philips_PCASL_2DEPI_PARREC_1,Siemens_PASL_3DGRASE_VE11C_1,Siemens_PASL_3DGRASE_VE11C_2 - The following datasets have CBF only, so they should have M0 set to Absent in Flavors:
Philips_PCASL_3DGRASE_5.1.7.2_1, - Fix Flavor Philips_PASL_2DEPI_5.4.1.0_ADNI3_006_S_6681_1 - M0 replaced with M0Type
- Fix Flavor Siemens_PCASL_3DGRASE_VB17A_multiPLD_1 - unknown issue
- Rename GE flavors folder names
- Should we then make M0_parms loading conditional upon ApplyQuantification(4)?
- TestDataSet 10% different results
Siemens3DGRASE_Structural_AlreadyDone_HiQ - Add 1.9.0 Reference to ResultsReference for TestDataSetTesting
- Fix UT test of xASL_wrp_BIDS2Legacy - neither test passed - issues with dro 2.3.0, not a real error
- Fix TestDataSet Philips_2DEPI_Segmentation_2 - slightly different - what parameter changed?!
- Fix TestDataSet Philips_2DEPI_FLAIR_Disabled - crashes because of ApplyQuantification 0 and M0 issues
- Fix UT test of xASL_ExploreASL - only test 9 failed - 'DRO 2.3.0 (Run processing starting from derivatives with dataPar.json input (outdated))'
- Finish testing Flavors
- Finish UT
- Finish TestDataSets
- If ExploreASL is initialized, it always searches for the dataset root folder, and will issue a warning if not specified
Release notes
General bug fixing of ExploreASL.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working