-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
Problem
-
We are still using the legacy version of the Drawer Navigator which is not using Reanimated 2.
-
I discovered that the DrawerView is not correctly picking up that Reanimated 2 is configured so it falls back to the "legacy" version of the drawer. The new code we want here is in a newer version of the
@react-navigation/drawerpackage. -
Upgrading will give massive improvements on Android to navigating and will allow us to use the
InteractionManagerto properly defer some expensive things we are doing until after the drawer opens/closes
HOWEVER...
There are two major blockers for this upgrade.
-
When the drawer performance is improved on Android it becomes so good that you see the previous chat before we display the new chat. Without the improvement today things just hang (for a few seconds) and we navigate to the new report. We will need to solve this somehow. Perhaps by showing the loader overlay as soon as a chat is tapped
-
Something about this upgrade is breaking the behavior of the drawer on mobile web. It will not open or close or respond to
DrawerActionsat all. We cannot fallback to theuseLegacyImplementationas we'll get this error:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
