This is how mapper function currently works#194
Merged
danburzo merged 2 commits intoEvercoder:mainfrom Mar 18, 2023
bijela-gora:tests/to-show-issues
Merged
This is how mapper function currently works#194danburzo merged 2 commits intoEvercoder:mainfrom bijela-gora:tests/to-show-issues
mapper function currently works#194danburzo merged 2 commits intoEvercoder:mainfrom
bijela-gora:tests/to-show-issues
Conversation
Collaborator
|
Thanks for this, @bijela-gora, I'll take a look and come back with an answer. |
Collaborator
|
Thanks again for the test cases! Indeed there are some bugs with the |
Collaborator
|
@bijela-gora I've corrected the |
Contributor
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @danburzo,
I hope you're doing well. I'm reaching out regarding my recent work on the TypeScript type definition for the culori library. I've noticed that the mapper function may not be behaving according to the documentation in some cases, and I wanted to bring this to your attention.
I'd appreciate it if you could take a look and confirm if the behavior is incorrect. I've marked the tests that show incorrect behavior with a comment "// might be incorrect".
Thank you for your time and attention.