This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Merged
Conversation
added 4 commits
January 10, 2017 15:04
- updated test pages to angular post-1.6.0 - ran e2e tests successfully for angular post-1.6.0 - error handling update to gulpfile
tomwayson
reviewed
Jan 22, 2017
Member
There was a problem hiding this comment.
Code looks good, but I get failing protractor tests:
1) Deferred Map should click on the load JSAPI button, and create a standard map view that is not rotated
Message:
Failed: No element found using locator: By(css selector, esri-map-view)
and
2) Registry Pattern should click on the map and scene views and begin showing click information in a text element
Message:
Expected 'none' to equal 'block'.
I don't have time to look at these right now, but I will later.
Member
|
I did not get a chance to look into those failing protractor tests. @jwasilgeo do the same tests fail for you? |
Contributor
Author
|
I don't think I hadn't those working either, and my suspicion is focused on the delayed/async nature of those tests. (As we know, getting protractor to delay and slow itself down has been moderately painful.) Shall we continue with them or shut off the tests? |
Member
|
I pulled the latest but I still get this error: |
Contributor
Author
|
Thanks for checking @tomwayson. I'm not seeing it yet but I'll have the opportunity to look a little deeper on another forthcoming PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #319
relates to #314 for master branch (I still have to apply the src code changes to v1 branch before that issue is fully resolved)