Skip to content

Fix integration tests#360

Merged
shenkeyao merged 126 commits intocelo-integration-rebase-16from
keyao/fix-integration-and-contracts
Mar 9, 2026
Merged

Fix integration tests#360
shenkeyao merged 126 commits intocelo-integration-rebase-16from
keyao/fix-integration-and-contracts

Conversation

@shenkeyao
Copy link
Copy Markdown
Member

@shenkeyao shenkeyao commented Feb 28, 2026

Closes https://app.asana.com/1/1208976916964769/project/1209976130071762/task/1213087831023898?focus=true.

This PR:

  • Fixes integration test CIs.

This PR does not:

  • Fix the devnet or contract tests.

Key places to review:

  • See the comments on files.

How to test this PR:

  • Verify that all CIs pass except for the devnet and contract tests.

@shenkeyao shenkeyao changed the base branch from celo-integration-rebase-16 to celo-integration-rebase-16.1 March 5, 2026 04:12
@shenkeyao shenkeyao changed the base branch from celo-integration-rebase-16.1 to celo-integration-rebase-16 March 5, 2026 05:26
@shenkeyao shenkeyao changed the title Fix integration and contract tests Fix integration tests Mar 5, 2026
Copy link
Copy Markdown
Member

@jjeangal jjeangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments!

Copy link
Copy Markdown
Collaborator

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippecamacho
Copy link
Copy Markdown
Collaborator

We should comment out the test that fail as this is expected.

@shenkeyao shenkeyao merged commit 7e0c3ed into celo-integration-rebase-16 Mar 9, 2026
15 of 21 checks passed
@shenkeyao shenkeyao deleted the keyao/fix-integration-and-contracts branch March 9, 2026 22:24
@shenkeyao
Copy link
Copy Markdown
Member Author

We should comment out the test that fail as this is expected.

@philippecamacho oops, I missed this comment before merging the PR! But I think it should be fine, since this PR wasn't merged to the default branch 14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants