Bump number of workers in Espresso submitter#340
Bump number of workers in Espresso submitter#340QuentinI wants to merge 1 commit intocelo-integration-rebase-14.2from
Conversation
Summary of ChangesHello @QuentinI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the performance of the Espresso transaction submitter by scaling up its worker capacity. The primary goal is to alleviate observed lag spikes within the sequencer-caff component, which is expected to lead to smoother and more efficient transaction handling. The change directly addresses a bottleneck by allowing more concurrent operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request increases the number of Espresso submitter workers from 4 to 32. While this aims to reduce lag spikes, the description notes that further increases don't necessarily help, suggesting potential diminishing returns or resource limits. The change itself is straightforward.
| WithEspressoClient(l.EspressoClient), | ||
| ) | ||
| l.espressoSubmitter.SpawnWorkers(4, 4) | ||
| l.espressoSubmitter.SpawnWorkers(32, 32) |
There was a problem hiding this comment.
The increase in worker count from 4 to 32 is substantial. While the PR description indicates this helps reduce lag spikes, it also notes that 'further increasing number of workers doesn't seem to help' and transactions still spend significant time in the queue. A fixed value of 32 might be arbitrary and could lead to resource contention or sub-optimal performance without a clearer understanding of the underlying bottleneck or system capacity. Consider making this value configurable to allow for easier tuning in different environments, or provide further justification for this specific number.
Closes #<ISSUE_NUMBER>
This PR:
Bumps the number of submission and verification workers in Espresso transaction submitter. This seems to reduce sequencer-caff lag spikes in my testing.
This PR does not
Fully resolve lag issue in submitter - transactions still spend tens of seconds in queue, which doesn't make a lot of sense. Further increasing number of workers doesn't seem to help. Will debug later.
Key places to review: