Implement transaction streaming in Go SDK#3604
Merged
Conversation
Contributor
|
Unable to build without Cargo.lock file. This means that after this change 3rd party projects may have For the first failing build see: https://github.com/EspressoSystems/espresso-network/actions/runs/17740884063 To reproduce locally run This PR can still be merged. |
c50dd7c to
c5db966
Compare
fd80f33 to
a896d36
Compare
a896d36 to
75ba0ad
Compare
Ayiga
reviewed
Sep 29, 2025
Ayiga
reviewed
Sep 29, 2025
75ba0ad to
bcea847
Compare
Ayiga
approved these changes
Oct 3, 2025
Member
Ayiga
left a comment
There was a problem hiding this comment.
Could use some comments on public methods and structs, but looks good overall
Contributor
Author
Fair, this is an SDK after all. I'll add some before merging. |
…ace filtering support - Remove StreamWithTimeout as Go's context already provides timeout capabilities - Add StreamTransactionsInNamespace method to stream transactions filtered by namespace - Update QueryService interface and MultipleNodesClient to support namespace filtering - Add tests for the new namespace filtering functionality
7796469 to
bd31a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: