fix(tui): disambiguate navigation to duplicate headings from outline#56
Merged
nicholasjpaterno merged 1 commit intoJun 2, 2026
Merged
Conversation
Selecting an outline item that appears multiple times in a document resulted in always jumping to the first occurence. This was caused by the lookup using the heading text as the key. Add an index field to HeadingNode and OutlineItem that stores each heading's position. All content extraction, selection restore, and rendering paths now resolve by index. extract_section(text) is kept unchanged for the CLI --section flag, which internally delegates to the new extract_section_at_index().
Contributor
|
Thanks @alisaifee I was able to confirm this bug locally. Thanks for the PR, everything looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Selecting an outline item that appears multiple times in a document resulted in always jumping to the first occurence. This was caused by the lookup using the heading text as the key.
Solution
Add a
indexfield toHeadingNodeandheading_indextoOutlineItemthat stores each heading's position inDocument::headings. All content extraction, selection restore, and rendering paths now resolve by index.extract_sectionis kept unchanged for the CLI--sectionflag, which internally delegates to the newextract_section_at_indexfunction.Demo