[remote] Improve .netrc test in RemoteModuleTest

Yannic · copybara-github · commit 33516e27dc6e · 2022-07-18T04:22:13.000-07:00
The return value being non-null doesn't assert that we actually parsed the (expected) `.netrc`. Closes bazelbuild#15902. PiperOrigin-RevId: 461583660 Change-Id: I0cd9a56c79a2177d89f67e2c541f38eb0ca24dcb
diff --git a/src/test/java/com/google/devtools/build/lib/remote/RemoteModuleTest.java b/src/test/java/com/google/devtools/build/lib/remote/RemoteModuleTest.java
@@ -566,6 +566,8 @@ public void testNetrc_netrcWithoutRemoteCache() throws Exception {
             clientEnv, fileSystem, reporter, authAndTLSOptions, remoteOptions);
 
     assertThat(credentials).isNotNull();
+    assertThat(credentials.getRequestMetadata(URI.create("https://foo.example.org"))).isNotEmpty();
+    assertThat(credentials.getRequestMetadata(URI.create("https://bar.example.org"))).isEmpty();
   }
 
   private static void assertRequestMetadata(

Original file line number	Diff line number	Diff line change
`@@ -566,6 +566,8 @@ public void testNetrc_netrcWithoutRemoteCache() throws Exception {`
`566`	`566`	`clientEnv, fileSystem, reporter, authAndTLSOptions, remoteOptions);`
`567`	`567`
`568`	`568`	`assertThat(credentials).isNotNull();`
	`569`	`+ assertThat(credentials.getRequestMetadata(URI.create("https://foo.example.org"))).isNotEmpty();`
	`570`	`+ assertThat(credentials.getRequestMetadata(URI.create("https://bar.example.org"))).isEmpty();`
`569`	`571`	`}`
`570`	`572`
`571`	`573`	`private static void assertRequestMetadata(`