[ul] Fix docs regarding renaming of feature tls to sync-tls#729
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Jan 31, 2026
Merged
[ul] Fix docs regarding renaming of feature tls to sync-tls#729Enet4 merged 1 commit intoEnet4:masterfrom
tls to sync-tls#729Enet4 merged 1 commit intoEnet4:masterfrom
Conversation
Enet4
approved these changes
Jan 31, 2026
Owner
Enet4
left a comment
There was a problem hiding this comment.
Spot on, no concerns with this! Thank you for noticing!
It appears that features sync-tls and async-tls (or at least the former) are not being tested in CI, as otherwise the compile error would have been apparent.
We are testing async-tls in CI, which already enables the same set of tests as if we were enabling this one and sync-tls. The situation with the doctest was that it was gated on the wrong Cargo feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I presume that the warning about not being sufficient to include "tls" and "async" is no longer necessary, given that after being renamed, it no longer makes sense to include "sync-tls" and "async", so I've removed them.
At the same time it adds no_compile to the doc example, that otherwise errors out because of missing .crt files.
Fixes #726.
Edit: It appears that features
sync-tlsandasync-tls(or at least the former) are not being tested in CI, as otherwise the compile error would have been apparent. @Enet4