[ul] Fix association establishment in presence of Extended Negotiation#727
Merged
Enet4 merged 2 commits intoEnet4:masterfrom Feb 5, 2026
Merged
Conversation
6f7d7e2 to
eac940a
Compare
Contributor
Author
|
Force-pushed after noticing a blunder. Sorry about that. |
This was referenced Feb 3, 2026
Closed
Enet4
reviewed
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the length field for the Service-class-application-information field, which is not supposed to have one. Add a unit test which tests the A-ASSOCIATE-RQ request against a full bytestream, and checks that it round-trips.
Fixes #725