[parser] Do not clear length of pixel data fragment item starts#693
Merged
[parser] Do not clear length of pixel data fragment item starts#693
Conversation
- Per PS3.5 A.4, the length of pixel data fragments are never undefined
- track whether DataSetWriter
is printing a pixel data fragment sequence
and keep lengths if so
- update test `dataset::write::write_encapsulated_pixeldata` accordingly
- Tweak documentation on ExplicitLengthSqItemStrategy
- [object] add test for writing a data set with encapsulated pixel data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #645 (CC @jmlaka).
Per PS3.5 A.4, the length of pixel data fragment items is always explicitly defined, so they should not be affected by the explicit length sequence strategy.
Summary
DataSetWriterprinting a pixel data fragment sequence and keep lengths if sodataset::write::write_encapsulated_pixeldataaccordingly