MAIN: Flush writer(s) after writing file meta and dataset#690
Merged
Enet4 merged 3 commits intoEnet4:masterfrom Oct 1, 2025
Merged
MAIN: Flush writer(s) after writing file meta and dataset#690Enet4 merged 3 commits intoEnet4:masterfrom
Enet4 merged 3 commits intoEnet4:masterfrom
Conversation
* In dataset serialization, add a final `flush` call to underlying writer, since `BufWriter` is the primary writer used, and the docs specify that `flush` should be called before `drop`
Enet4
approved these changes
Oct 1, 2025
Owner
Enet4
left a comment
There was a problem hiding this comment.
Looks OK. It's better to check that the last bytes were written than to encounter weird edge cases one day and spend hours debugging it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While noodling around on #649 I came across this line of docs on
std::io::BufWriterThis PR adds a flush method to each of the dataset writing "stack" (
StatefulEncoderandDataSetWriter), which is then called in theFileDicomObject::write_dataset_implto ensure the writer (specifically theBufWriterused in bothwrite_all,write_to_file, andwrite_dataset) are flushed before being dropped.