Skip to content

Add gbk charset#682

Merged
Enet4 merged 5 commits intoEnet4:masterfrom
momostarsky:add-gbk-charset
Sep 13, 2025
Merged

Add gbk charset#682
Enet4 merged 5 commits intoEnet4:masterfrom
momostarsky:add-gbk-charset

Conversation

@momostarsky
Copy link
Copy Markdown

GBK rename to Gbk . And Gbk support "ISO 2022 IR 58" and "GB2312"

@Enet4 Enet4 added A-lib Area: library C-encoding Crate: dicom-encoding enhancement labels Sep 8, 2025
@Enet4 Enet4 self-requested a review September 8, 2025 09:53
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping this PR fresh! Two more things to adjust and it's ready to be merged.

- update character set support table
- format code
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge. Feel free to file new issues or send a pull request if more improvements are needed.

@Enet4 Enet4 merged commit 1f16e9b into Enet4:master Sep 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library C-encoding Crate: dicom-encoding enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants