Add option to override per-VR character set usage#676
Conversation
naterichman
left a comment
There was a problem hiding this comment.
Sorry if I'm missing something, but figured I would hop on a review in case it helped!
|
@Enet4 Hi, why hasn't this PR been merged yet? Is there anything blocking it? Does it need more testing? |
|
I just didn't get to it yet. Let me assess and revise on Nathan's comment first, hopefully within the next few days. |
- CharacterSetOverride allows one to indicate that the more extended character repertoire available should be used for decoding other VRs such as CS.
… object - re-export dicom_parser options accordingly
3941f03 to
6231ccf
Compare
- Include UR in VRs which should use the default character set
|
I rebased the branch and added UR as one of the VRs to use the default character set by default. Things seem to be in order. @momostarsky I noticed a deleted post here, are there still any issues? |
|
@Enet4 It might be an issue with testing or configuration. I'll verify later using storescu and storescp to check if it affects read/write operations. |
|
@Enet4 Building on the earlier tests, Test some DICOM files with character sets such as "ISO 192", "ISO 100", "GB18030", and "ISO 2022 IR 58". Modify the storescp implementation in store_sync.rs around line 192, add code similar to the following: ''' |
|
That sounds to offer good coverage already, thanks! If in the meantime you found what could be considered a bug, please file a new issue. |
Should resolve #675 by offering a way to ignore the fact that some VRs should always use the default character repertoire.
Summary