Fix bit_allocation 1 for decode_pixel_data#668
Merged
Enet4 merged 13 commits intoEnet4:masterfrom Aug 14, 2025
Merged
Conversation
Enet4
reviewed
Jul 29, 2025
Owner
Enet4
left a comment
There was a problem hiding this comment.
Oof! Thank you for spotting this nevertheless!
BTW: Is decode_pixel_data() the same as decode_pixel_data(0)?
It is not. :) decode_pixel_data will take and decode all pixel data found in the file (all frames!), which may be useful if the intent is to build a voxel volume. Working each frame one by one through the other method will be more efficient.
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
Enet4
reviewed
Aug 6, 2025
Contributor
Author
|
I have also extended the tests to check all decode_pixel_data(0..2) and to_dynamic_image(0..2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#654 only implemented bit_allocation == 1 for decode_pixel_data_frame(index) but missed it for decode_pixel_data().
BTW: Is decode_pixel_data() the same as decode_pixel_data(0)?