Skip to content

Clippy lint fix for v1.88#655

Merged
Enet4 merged 21 commits intomasterfrom
chore/clippy-lint-fix_1.88
Jun 29, 2025
Merged

Clippy lint fix for v1.88#655
Enet4 merged 21 commits intomasterfrom
chore/clippy-lint-fix_1.88

Conversation

@Enet4
Copy link
Copy Markdown
Owner

@Enet4 Enet4 commented Jun 27, 2025

  • [core] Clippy lint fix
  • [dictionary-builder] Clippy lint fix
  • [dictionary-std] Clippy lint fix
  • [dump] Clippy lint fix
  • [encoding] Clippy lint fix
  • [ts-registry] Clippy lint fix
  • [parser] Clippy lint fix
  • [ul] Clippy lint fix
  • [findscu] Clippy lint fix
  • [fromimage] Clippy lint fix
  • [json] Clippy lint fix
  • [object] Clippy lint fix
  • [pixeldata] Clippy lint fix
  • [scpproxy] Clippy lint fix
  • [toimage] Clippy lint fix

Enet4 added 15 commits June 27, 2025 08:58
- use implicit named arguments in formatting macros when possible
- remove leading zeros from integer numbers
- disambiguate leading null character
- remove multiplications by 1
- use unit type identifier to construct dictionary instead of default()
- implicit named arguments in formatting macros when possible
- unnecessary 'static lifetime in const slice
- call `stream_position()` instead of `seek(Current(0))`
- implicit named arguments in formatting macros when possible
- remove leading zeros in integers
- unneeded forced coercion of byte string literal
- implicit named arguments in formatting macros when possible
- simplify asserts
- simplify PixelDataObject impl for TestDataObject
- change assert to type check in util
- unit type construction
- unnecessary 'static lifetime in const slice
- implicit named arguments in formatting macros when possible
- implicit named arguments in formatting macros when possible
- unit type construction
- change test for empty array
- fix checks in can_read_write_pdata so that it actually asserts the intended matches
- implicit named arguments in formatting macros when possible
- implicit named arguments in formatting macros when possible
- needless borrow
- implicit named arguments in formatting macros when possible
- simplify assertion and matches
- needless borrows
- implicit named arguments in formatting macros when possible
- simplify assertion and matches
- needless 'static lifetime in const slices
- change cast to literal suffix where possible
- implicit named arguments in formatting macros when possible
- implicit named arguments in formatting macros when possible
@Enet4 Enet4 added chore For keeping the project tidy C-object Crate: dicom-object C-encoding Crate: dicom-encoding C-parser Crate: dicom-parser C-dictionary Crate: dictionary-std C-core Crate: dicom-core C-pixeldata Crate: dicom-pixeldata C-transfer-syntax Crate: dicom-transfer-syntax-registry C-ul Crate: dicom-ul C-fromimage Crate: dicom-fromimage C-dictionary-builder Crate: dicom-dictionary-builder C-dump Crate: dicom-dump C-toimage Crate: dicom-toimage C-findscu Crate: dicom-findscu C-json Crate: dicom-json labels Jun 27, 2025
@Enet4 Enet4 added the C-scpproxy Crate: dicom-scproxy label Jun 27, 2025
@Enet4 Enet4 merged commit 81d0a7f into master Jun 29, 2025
5 checks passed
@Enet4 Enet4 deleted the chore/clippy-lint-fix_1.88 branch June 29, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-core Crate: dicom-core C-dictionary Crate: dictionary-std C-dictionary-builder Crate: dicom-dictionary-builder C-dump Crate: dicom-dump C-encoding Crate: dicom-encoding C-findscu Crate: dicom-findscu C-fromimage Crate: dicom-fromimage C-json Crate: dicom-json C-object Crate: dicom-object C-parser Crate: dicom-parser C-pixeldata Crate: dicom-pixeldata C-scpproxy Crate: dicom-scproxy C-toimage Crate: dicom-toimage C-transfer-syntax Crate: dicom-transfer-syntax-registry C-ul Crate: dicom-ul chore For keeping the project tidy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant