Skip to content

Update charls dependency to version 0.4.2#644

Merged
Enet4 merged 3 commits intoEnet4:masterfrom
dougyau:charls-cmake
May 27, 2025
Merged

Update charls dependency to version 0.4.2#644
Enet4 merged 3 commits intoEnet4:masterfrom
dougyau:charls-cmake

Conversation

@dougyau
Copy link
Copy Markdown
Contributor

@dougyau dougyau commented Apr 10, 2025

cmake v3.27 introduced CMAKE_LINK_DEPENDS_USE_LINKER define (https://cmake.org/cmake/help/latest/variable/CMAKE_LINK_DEPENDS_USE_LINKER.html) which breaks the build of charls, specially when doing cross compilation.

To fix it CMAKE_LINK_DEPENDS_USE_LINKER=0 is required.

dougyau added 2 commits April 9, 2025 22:54
@dougyau
Update charls dependency to version 0.4.1
5bf5be5 
cmake v3.27+ compatibility
@dougyau
Update charls and charls-sys dependencies to latest versions
0c6d91e 
Upgraded `charls` to version 0.4.2 and `charls-sys` to version 2.4.4. This ensures compatibility with the latest features, bug fixes, and improvements provided by the upstream libraries.
@dougyau dougyau changed the title Update charls dependency to version 0.4.1 Update charls dependency to version 0.4.2 Apr 24, 2025
@dougyau
Copy link
Copy Markdown
Contributor Author

dougyau commented Apr 24, 2025

Updated the dependency to 0.4.2

It includes the change to streamline the package. Additional change on that library is the vcpkg feature flag which is useful on windows.

Should I add a charls_vcpkg feature flag on this project? What do you think?

@Enet4
Copy link
Copy Markdown
Owner

Enet4 commented May 14, 2025

It includes the change to streamline the package. Additional change on that library is the vcpkg feature flag which is useful on windows.

Should I add a charls_vcpkg feature flag on this project? What do you think?

Oops, I must've overlooked this question. I just gave that a try (add feature charls_vcpkg to dicom-transfer-syntax-registry and dicom-pixeldata) on a Windows machine. It seems to work rather well after installing charls for x64-windows-static triplet. Great work!

The only downside is that each new feature in dicom-transfer-syntax-registry is replicated to dicom-pixeldata, but this is acceptable for the time being.

@Enet4 Enet4 added enhancement A-lib Area: library C-pixeldata Crate: dicom-pixeldata C-transfer-syntax Crate: dicom-transfer-syntax-registry labels May 14, 2025
Enet4
Enet4 approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again!

@Enet4 Enet4 merged commit 3f4a12e into Enet4:master May 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees

No one assigned

Labels

A-lib Area: library C-pixeldata Crate: dicom-pixeldata C-transfer-syntax Crate: dicom-transfer-syntax-registry enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dougyau @Enet4