Conversation
5ce94d6 to
99df1fc
Compare
- add utility constructor functions to Codec - generalize submit_ele_transfer_syntax! macro so that it is usable in non-stub scenarios - add TransferSyntax::pixel_data_reader and TransferSyntax::pixel_data_writer
99df1fc to
cce5feb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that
submit_ele_transfer_syntax!was not usable unless to specify a stub. This is not ideal, but since type parameter defaults are not supported, theCodecexpression in the macro has to be annotated with the remaining types. I added some associated constructor functions to help mitigate this.Summary
Codecsubmit_ele_transfer_syntax!macro so that it is usable in non-stub scenariosTransferSyntax::pixel_data_readerandTransferSyntax::pixel_data_writerto inspect the pixel data decoder and encoder