Add support for non-finite float handling in DICOM JSON#615
Merged
Enet4 merged 2 commits intoEnet4:masterfrom Dec 23, 2024
Merged
Add support for non-finite float handling in DICOM JSON#615Enet4 merged 2 commits intoEnet4:masterfrom
Enet4 merged 2 commits intoEnet4:masterfrom
Conversation
Enet4
reviewed
Dec 22, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Thank you for your pull requests! I just added a few minor suggestions, things should be in order once they are resolved.
Author
|
Released a new version to incorporate your feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered a few unusual DICOM files that store NaN, inf, and -inf values in float tags. These values appear to be valid according to the DICOM Standard.
This pull request adds support for serializing non-finite float values to DICOM JSON. Previously, these values were serialized to
nullcausing the values to dissapear.Changes:
Added proper handling for non-finite float values (NaN, inf, -inf) during DICOM JSON serialization.
Added a test to verify deserialization logic correctly parses these values from their DICOM JSON representations.
Verification:
Tested with several DICOM files containing NaN, inf, and -inf values.
Ensured that all non-finite float values remain intact after serializing and deserializing them to and from DICOM JSON and DICOM.