Add character sets: Arabic, Greek, Hebrew, Japanese, Thai, Korean#614
Add character sets: Arabic, Greek, Hebrew, Japanese, Thai, Korean#614Enet4 merged 1 commit intoEnet4:masterfrom
Conversation
|
Thank you for your pull request! Do you happen to know whether any of these encodings also have an implementation at
A curious reference. The normative part of the standard would be in PS3.5 section 6.1, though I agree that the latest revisions do not expose the available character sets as nicely as in that table. |
|
Based on a review of the encoding_rs_compat library, all of the new character sets are compatible with encoding_rs (see: compat.rs. So I don't think that this change will be a blocker to switching. Yeah, I just found the |
Enet4
left a comment
There was a problem hiding this comment.
OK, this seems to be in order. It's also good to hear that compatibility layers towards encoding_rs are a possibility. Thanks!
|
Thanks Eduardo! Appreciate your quick responses. |
This change adds support for the following character sets:
This is related to issue: #40, and is a superset of the currently open PR #444.
The full set of DICOM supported character sets is listed in: Table D.6.2-1. Supported Specific Character Set Defined Terms. This change covers the character sets in this list which are also supported by rust-encoding.
It appears that
rust-encodingdoes not include support for ISO-IR 148 (Latin 5) or ISO-IR 159 (Japanese supplementary characters), so these have not been included.