Do not set query retrieve level for worklist#603
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Dec 7, 2024
Merged
Conversation
Enet4
reviewed
Dec 7, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Well, it is true that PS3.4 K.6.1 does not mention Query/Retrieve Level (0008,0052) anywhere. All the other references I could find just say that MWL querying is equivalent to C-FIND with the corresponding SOP Class UID.
I can only test with other software next week, but it should be OK.
ac831bc to
8c1621b
Compare
Enet4
reviewed
Dec 7, 2024
9e8fbf0 to
f66ef73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #602
Not 100% sure if fix is proper, but without QueryRetrieveLevel in our internal app we already gather worklist since ~1 year without any problems
I also forced
cargo clippyto fail, when there are any warnings(I also fixed 1 other warning, to pass checks)