Merged
Conversation
… compatibility - Result::inspect and Option::inspect were introduced in 1.76.0
5ee88c5 to
a9837a8
Compare
Enet4
reviewed
Nov 1, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Thank you for the initiative. This should take part in 0.8.0 with a minor revision.
Enet4
reviewed
Nov 2, 2024
a9837a8 to
681dd11
Compare
681dd11 to
12a03ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets minimal rust version to 1.72.
Verification that libraries with default features compile with Rust 1.72 is included in the CI.
This version of rust is not enforced for binary projects and custom features, because they depend on external libraries that often increase the minimal versions of rust(an example is clap - 4.0(<1.72) and already 4.5(1.74))
Some tests failed on Rust 1.72.0, so I increased error size
Also due adding clippy.toml, clippy now should only report problems that don't need rust >=1.73
PR depends and contains #586