[pixeldata] Handle empty NumberOfFrames tags#576
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Oct 23, 2024
Merged
Conversation
Enet4
approved these changes
Oct 23, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Sure, sounds fair. Providing an empty Number Of Frames does not seem compliant from my interpretation of the standard, but is simple to handle with hardly any downsides. Thank you. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure of what the semantic difference between "absent tag" and "empty tag" is, but I do have some XRays with an empty "NumberOfFrames" tag.