[pixeldata] Add support for PixelFirst planar configuration (#129)#575
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Oct 25, 2024
Merged
[pixeldata] Add support for PixelFirst planar configuration (#129)#575Enet4 merged 1 commit intoEnet4:masterfrom
Enet4 merged 1 commit intoEnet4:masterfrom
Conversation
Enet4
approved these changes
Oct 25, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
The code is sound and clean. I would not worry too much about optimizing it aggressively at this time. It is great to have support for the pixel first planar configuration. Much appreciated! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds a very simple interleave function to handle planar pixel configurations when decoding pixel data. I only have planar RGB8 files to test, but I don't see why 16-bit files would behave very differently...
The interleave implementation is very simple, but seems to yield decent performance (30ms to interleave a 12MP image on my 10 year old laptop). I experimented with a more "imperative" version with for loops which ended up being slower (probably because of bound checks), and a simple SSE implementation based on mm_shuffle_epi8 wasn't significantly faster either.