Client Association connection timeout working#570
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Oct 13, 2024
Merged
Conversation
- multiple SocketAddrs accepted
Enet4
approved these changes
Oct 13, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Right, looks good. Thank you for the follow-up!
I did not write a test for the connection timeout functionality, as it is not possible to simulate
a connection timeout with the currently used test tooling inside the library.
( TcpListener::accept() cannot be used for this)
Testing the happy path would be possible in one of the integration tests in tests. Ensuring that the timeout is truly in place is something which I suspect would either demand a custom TCP implementation or some system-level scaffolding to control address name resolution for the test suite. But for now we'll go with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the empty SocketAddr iterator check, as it was too complicated and did not add much information.
The previous, faulty pull request counted the iterator and consumed it in the process, thus the error.
I did not write a test for the connection timeout functionality, as it is not possible to simulate
a connection timeout with the currently used test tooling inside the library.
(
TcpListener::accept()cannot be used for this)