Skip to content

Fix typos found by codespell#558

Merged
Enet4 merged 1 commit intoEnet4:masterfrom
DimitriPapadopoulos:codespell
Sep 13, 2024
Merged

Fix typos found by codespell#558
Enet4 merged 1 commit intoEnet4:masterfrom
DimitriPapadopoulos:codespell

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 31, 2024

No description provided.

Enet4
Enet4 reviewed Aug 31, 2024
View reviewed changes
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, some typos slip occasionally and they add up. It's curious that typos such as the one in partial.rs:310 wasn't picked up, were they explicitly excluded because they are already fixed in #557?

dictionary-std/src/uids.rs
#[rustfmt::skip]
pub const IMPLANT_TEMPLATE_GROUP_INFORMATION_MODEL_GET: &str = "1.2.840.10008.5.1.4.45.4";
/// Application Hosting Modle: Native DICOM Model
/// Application Hosting Model: Native DICOM Model
Copy link
Copy Markdown
Owner

@Enet4 Enet4 Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the typo leaked into the generated files. It's fine to fix them here, might also think about generating updated files soon.

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

DimitriPapadopoulos commented Sep 1, 2024

The codespell tool is based on a dictionary of common typos, retrievies was not part of that dictionary.

I have added this typo in codespell-project/codespell#3530.

@Enet4 Enet4 added bug This is a bug C-object Crate: dicom-object C-encoding Crate: dicom-encoding C-dictionary Crate: dictionary-std C-core Crate: dicom-core C-transfer-syntax Crate: dicom-transfer-syntax-registry C-dictionary-builder Crate: dicom-dictionary-builder C-storescp Crate: dicom-storescp C-parser Crate: dicom-parser C-pixeldata Crate: dicom-pixeldata C-echoscu Crate: dicom-echoscu labels Sep 3, 2024
Enet4
Enet4 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you. 👍

@Enet4 Enet4 merged commit a94307d into Enet4:master Sep 13, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch September 13, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees

No one assigned

Labels

bug This is a bug C-core Crate: dicom-core C-dictionary Crate: dictionary-std C-dictionary-builder Crate: dicom-dictionary-builder C-echoscu Crate: dicom-echoscu C-encoding Crate: dicom-encoding C-object Crate: dicom-object C-parser Crate: dicom-parser C-pixeldata Crate: dicom-pixeldata C-storescp Crate: dicom-storescp C-transfer-syntax Crate: dicom-transfer-syntax-registry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @Enet4