BUG: Use only odd presentation context IDs#552
Merged
Enet4 merged 3 commits intoEnet4:masterfrom Aug 6, 2024
Merged
Conversation
Contributor
Author
|
Ah, found this: https://dicom.nema.org/medical/dicom/current/output/chtml/part08/sect_9.3.2.2.html
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really sure why, but I had an SCP I was talking to and trying to pass multiple presentation context IDs and it was failing. I tried with a different implementation (pydicom) and it worked, looking at a packet capture the only difference was that they passed a couple of other transfer syntaxes (explicit VR big endian, and deflated), and that they only used odd numbers for presentation context ids.
I couldn't find anything in the standard to support that, but I tried changing it and it worked...
Code to reproduce:
Before the change, output:
after: