Infer Media Storage SOP Class UID and Media Storage SOP Instance UID from the SOP Class UID and SOP Instance UID when missing#541
Merged
Enet4 merged 2 commits intoEnet4:masterfrom Jul 21, 2024
Conversation
…from the SOP Class UID and SOP Instance UID when missing - Default Media Storage SOP Class UID and Media Storage SOP Instance UID to empty string when not available in the DICOM meta information table. - In open_file_with_all_options attempt to infer the Media Storage SOP Class UID and Media Storage SOP Instance UID from the SOP Class UID and SOP Instance UID tag values if the Media Storage SOP Class UID and Media Storage SOP Instance UID are set to an empty string
Enet4
reviewed
Jul 21, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Thank you for working on this! This is almost ready to enter. Please see the suggestions inline.
object/src/lib.rs
Outdated
| #[snafu(backtrace)] | ||
| source: crate::meta::Error, | ||
| }, | ||
| ParseSopAttributes { |
Owner
There was a problem hiding this comment.
As each error pertains to a single SOP attribute, the singular form (ParseSopAttribute) might be a better name.
Don't forget to include a suitable display message, either using #[display(...)] or with a doc comment.
Author
There was a problem hiding this comment.
That's a good point. Released an updated version to address these
…ssage Update ParseSopAttributes Error to be singular and include display message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #538
open_file_with_all_optionsattempt to infer the Media Storage SOP Class UID and Media Storage SOP Instance UID from the SOP Class UID and SOP Instance UID tag values if the Media Storage SOP Class UID and Media Storage SOP Instance UID are set to an empty string