MAIN: Add read/write timeout options for ClientAssociation#530
Merged
Enet4 merged 2 commits intoEnet4:masterfrom Jul 5, 2024
Merged
MAIN: Add read/write timeout options for ClientAssociation#530Enet4 merged 2 commits intoEnet4:masterfrom
Enet4 merged 2 commits intoEnet4:masterfrom
Conversation
Enet4
reviewed
Jul 4, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Looks mostly OK, I believe this is as far as we can go before moving onto async. I suggested some minor changes below.
Please don't forget to rebase to solve the existing git conflicts.
ed5ac46 to
f330540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small MR to add read/write timeouts for the TCPStream on a ClientAssociation object.
I am using the client extensively and find that some pacs servers (presumably when under load) are taking 1000+s to respond to a c-move.
Additionally when I get around to it I will add over my c-move implementation.
As a side-note I've used it as a learning point for async rust and have made processes as async as possible (i.e just
spawn_blockingas little as I can) and that has been interesting, but it would definitely be great to make the Client and Server async compatible themselves.