Change monochrome reinterpretation requirements from pixel data readers#498
Merged
Change monochrome reinterpretation requirements from pixel data readers#498
Conversation
…mplementations When decoding monochrome images, `decode` and `decode_frame` should retain the photometric interpretation of the source object (monochrome1 or monochrome2) This is the most intuitive approach with less effort for decoders. Plus clarify that the frame index is 0-based
…oding - decoding a monochrome image no longer implies a change to the photometric interpretation
- gdcm decoder will also convert monochrome1 to monochrome2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a mismatch between the pixel data readers' monochrome output and the way that said output was being used, thus fixing cases where the photometric interpretation was being erroneously changed from MONOCHROME1 to MONOCHROME2 for encapsulated pixel data.
Summary
decodeanddecode_frameshould retain the photometric interpretation of the source object (monochrome1 or monochrome2)This is the most intuitive approach with less effort for decoders. It does not apply to GDCM integration though, which will convert monochrome1 images to monochrome2.