Skip to content

Update image lib#491

Merged
Enet4 merged 1 commit intoEnet4:masterfrom
leonz:master
Apr 8, 2024
Merged

Update image lib#491
Enet4 merged 1 commit intoEnet4:masterfrom
leonz:master

Conversation

@leonz
Copy link
Copy Markdown

@leonz leonz commented Apr 3, 2024

Bumps the image-rs dependency to 25.1.

Two changes to features:
image-rs/image@7c841c4
image-rs/image@81b3fe6

@leonz
Copy link
Copy Markdown
Author

leonz commented Apr 3, 2024

Hi @Enet4, would appreciate a review on this if possible. This will enable us to bump the image library in our own project.

@Enet4 Enet4 added A-lib Area: library C-pixeldata Crate: dicom-pixeldata C-toimage Crate: dicom-toimage labels Apr 3, 2024
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. It's with good timing that we bump image to 0.25, so that it is incorporated into the 0.7 milestone.

There is a known caveat that JPEG lossless image files will no longer work as input to dicom-fromimage (image-rs/image#1877 (comment)), but this is a very minor situation which I believe no one is strongly depending on. JPEG baseline and JPEG lossless decoding will continue to depend on jpeg-decoder directly, meaning that we may have multiple JPEG decoder implementations in the final build for now. Maybe one day DICOM-rs can too move to zune-jpeg for decoding (etemesi254/zune-image#144).

@Enet4 Enet4 added this to the DICOM-rs 0.7 milestone Apr 8, 2024
@Enet4 Enet4 merged commit d5c9606 into Enet4:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library C-pixeldata Crate: dicom-pixeldata C-toimage Crate: dicom-toimage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants