Skip to content

Implement virtual VR concept in data element dictionary entries#478

Merged
Enet4 merged 4 commits intomasterfrom
change/core/element-dict-xvr
Apr 12, 2024
Merged

Implement virtual VR concept in data element dictionary entries#478
Enet4 merged 4 commits intomasterfrom
change/core/element-dict-xvr

Conversation

@Enet4
Copy link
Copy Markdown
Owner

@Enet4 Enet4 commented Mar 16, 2024

This implements an extension to the concept of value representation so that data element dictionaries can represent. dictionary-builder and dictionary-std have been updated accordingly.

Summary

  • [core] Use virtual vr in element dictionary entries
  • [dictionary-builder] Update tags builder to provide virtual VR
  • [dictionary-std] Update tags.rs to conform with new dictionary entry format
  • [parser] Simplify pixel representation VR translation

@Enet4 Enet4 added breaking change Hint that this may require a major version bump on release A-lib Area: library C-core Crate: dicom-core labels Mar 16, 2024
Enet4 added 4 commits March 20, 2024 08:56
- Add VirtualVr type and use it
- [dictionary-std][encoding][findscu][object] Implement the necessary translations in the other crates
- look up data element dictionary
  for virtual VR Xs
  instead of keeping a hardcoded list of tags
@Enet4 Enet4 force-pushed the change/core/element-dict-xvr branch from 5e04d97 to 0d9c16a Compare March 20, 2024 08:56
@Enet4 Enet4 added C-dictionary Crate: dictionary-std C-dictionary-builder Crate: dicom-dictionary-builder labels Mar 27, 2024
@Enet4 Enet4 added this to the DICOM-rs 0.7 milestone Apr 10, 2024
@Enet4 Enet4 merged commit 938d818 into master Apr 12, 2024
@Enet4 Enet4 deleted the change/core/element-dict-xvr branch April 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library breaking change Hint that this may require a major version bump on release C-core Crate: dicom-core C-dictionary Crate: dictionary-std C-dictionary-builder Crate: dicom-dictionary-builder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant