Merged
Conversation
Enet4
reviewed
Mar 6, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Thank you very much for this! Please see the comments inline.
76314b9 to
ff5a8de
Compare
When encountering PixelRepresentation set a flag so we get the correct VR for PixelPadding and other affected elements.
Enet4
approved these changes
Mar 10, 2024
Owner
Enet4
left a comment
There was a problem hiding this comment.
Looks good! I will begin some work on the core and dictionary-std crate to encompass extra information about the data element so that we can use it here. But in the meantime, this works better than before. Thank you @thomas-tribus!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering PixelRepresentation set a flag so we get the correct VR for PixelPadding