Add function for changing charset with unit test.#456
Conversation
thomas-tribus
commented
Feb 14, 2024
- Creates a function to change the charset
- Adds a unit test to test if the sequences have invalid length when converting into tokens
- Does not yet change the generation of tokens yet.
Enet4
left a comment
There was a problem hiding this comment.
Thank you very much for the initiative, @thomas-tribus! It may be so that we ought to pass charset_changed along into the IntoTokens implementation.
From looking at the test method, I should note that the data set writer might already choose to ignore the encoded element lengths and pick the real byte length instead (#172). This is probably not happening for SQs yet because without the flag, we did not have a way to know in advance whether making the SQ length undefined is needed.
More comments inline.
|
Thanks @Enet4, I don't have time today, so I'll look at this tomorrow 👍 |
|
@Enet4 I had a quick look at how I could add the flag to |
0becca5 to
07bfd5a
Compare
bfe4c44 to
392d275
Compare
392d275 to
012ce48
Compare
012ce48 to
926baba
Compare
926baba to
8cf1065
Compare
8cf1065 to
693c671
Compare
- Creates a function to change the charset - Adds a unit test to test if the sequences have invalid length when converting into tokens - When putting the 'specific charset' token, set a flag to invalidate all lengths when writing the dicom - In the token generation code, check and pass this token, marking all lengths as UNDEFINED
693c671 to
846a53e
Compare
Enet4
left a comment
There was a problem hiding this comment.
Ready to bring this in. 👍 Thanks again, @thomas-tribus!
|
Happy to contribute in a very small way!
…On Wed, Mar 27, 2024 at 2:44 PM Eduardo Pinho ***@***.***> wrote:
***@***.**** approved this pull request.
Ready to bring this in. 👍 Thanks again, @thomas-tribus
<https://github.com/thomas-tribus>!
—
Reply to this email directly, view it on GitHub
<#456 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHQ42RZPCYBTCQBAOJYAKTY2K5KLAVCNFSM6AAAAABDIGKT7WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRTGM3TSNZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|