Skip to content

Adjust features for easier building on Windows#433

Merged
Enet4 merged 4 commits intomasterfrom
chore/features_windows
Nov 5, 2023
Merged

Adjust features for easier building on Windows#433
Enet4 merged 4 commits intomasterfrom
chore/features_windows

Conversation

@Enet4
Copy link
Copy Markdown
Owner

@Enet4 Enet4 commented Nov 3, 2023

This attempts to mitigate the build error when targeting Windows without Cargo feature changes (#432). Removing feature openjp2 from the native feature list is a breaking change, but we can offer alternative feature listings for Windows.

So instead of this:

cargo build --no-default-features --features=cli,rle,jpeg,rayon

One can instead do this:

cargo build --no-default-features --features=cli,default_windows

Or this, for the reference implementation of OpenJPEG:

cargo build --no-default-features --features=cli,default_windows,openjpeg-sys,openjpeg-sys-threads

Summary

  • Add native_windows Cargo feature to dicom-transfer-syntax-registry and dicom-pixeldata
  • Add default_windows Cargo feature to dicom-pixeldata
  • Clarify documentation on JPEG 2000 adapter
  • Add compile-time check for conflicting jpeg2k backend feature selection
  • Change CI to build project on Windows instead of just checking

@Enet4 Enet4 added A-lib Area: library O-windows Operating System: Windows labels Nov 3, 2023
@Enet4 Enet4 marked this pull request as ready for review November 3, 2023 13:56
@Enet4 Enet4 merged commit 07a2310 into master Nov 5, 2023
@Enet4 Enet4 deleted the chore/features_windows branch November 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library O-windows Operating System: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant