Skip to content

Project maintenance (2023-10)#427

Merged
Enet4 merged 2 commits intomasterfrom
chore/maintenance-2023-10
Oct 30, 2023
Merged

Project maintenance (2023-10)#427
Enet4 merged 2 commits intomasterfrom
chore/maintenance-2023-10

Conversation

@Enet4
Copy link
Copy Markdown
Owner

@Enet4 Enet4 commented Oct 30, 2023

  • Update Cargo lock files
  • Update GitHub actions workflow

@Enet4 Enet4 added the chore For keeping the project tidy label Oct 30, 2023
@Enet4
Copy link
Copy Markdown
Owner Author

Enet4 commented Oct 30, 2023

Re failed job:

---- value::partial::tests::test_dicom_time stdout ----
thread 'value::partial::tests::test_dicom_time' panicked at core/src/value/partial.rs:972:87:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/std/src/panicking.rs:597:5
   1: core::panicking::panic_fmt
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:127:5
   3: core::option::Option<T>::unwrap
   4: dicom_core::value::partial::tests::test_dicom_time
   5: dicom_core::value::partial::tests::test_dicom_time::{{closure}}
   6: core::ops::function::FnOnce::call_once
   7: core::ops::function::FnOnce::call_once
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/ops/function.rs:250:5

It points to this part:

        assert!(matches!(
            DicomTime::try_from(&NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000).unwrap()),
            Err(Error::InvalidComponent {
                component: DateComponent::Fraction,
                ..
            })
        ));

It appears that NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000) was not accepted by chrono this time. Checking if this is consistent.

@Enet4 Enet4 mentioned this pull request Oct 30, 2023
Merged
Enet4 added 2 commits October 30, 2023 19:12
@Enet4
Update Cargo lock files
15a2a13 
- cargo update
@Enet4
Update main GitHub workflow
d5ee0e6 
- update actions/checkout
- merge Clippy run onto main Linux job
- add check on macOS
@Enet4 Enet4 force-pushed the chore/maintenance-2023-10 branch from 8d8a455 to d5ee0e6 Compare October 30, 2023 19:12
@Enet4 Enet4 merged commit 3fb3279 into master Oct 30, 2023
@Enet4 Enet4 deleted the chore/maintenance-2023-10 branch October 30, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore For keeping the project tidy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Enet4