Conversation
24 tasks
- [ts-registry] add features openjp2 and openjpeg-sys - map to the backend impl of JPEG 2000 via jpeg2k - [ts-registry] add JPEG 2000 pixel data adapter with decoding support - [pixeldata] expose more transfer-syntax-registry features - [pixeldata] adjust jpeg decoding test cases according to support - [toimage] relocate dicom-pixeldata/native to default features so that native implementations can be disabled at will
e3db021 to
2844d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds direct support for decoding pixel data in JPEG 2000, via jpeg2k.
jpeg2klets us pick between linking the reference implementation of OpenJPEG (Cargo featureopenjpeg-sys) or a Rust port (Cargo featureopenjp2).A few more changes were made to the Cargo feature set so that downstream crates can be more specific about which via
dicom-pixeldata.For instance, doing
cargo install --path toimagewould include the Rust port of openjp2, but with the command below, you can builddicom-toimagestatically linked with the OpenJPEG reference software.cargo install --path toimage --no-default-features \ --features=dicom-pixeldata/jpeg,dicom-pixeldata/rle,dicom-pixeldata/openjpeg-sysSummary
openjp2andopenjpeg-sysdicom-pixeldata/nativeto default features, so that native implementations can be disabled at will