Decode a single frame via object pixel data decoding API#421
Merged
Conversation
- A method that retrieves about the same imaging metadata, but only decodes one frame. - Contains default implementation (inefficient but prevents breaking changes) - Implement it for default DICOM object (not gdcm) - Clear some redundancy using new struct ImagingProperties - from_obj provides lots of metadata at once - add specific error variant for no pixel data
- decodes only what's necessary, makes things more efficient
- do no copies if the raw pixel data is native and needed no processing
- InnerError was mistakenly made public
f9ea72e to
34be166
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it was possible to retrieve a single frame from a blob of decoded pixel data, the API provided by
PixelDecoderrequired the user to decode all of the frames first.This PR extends this trait for the possibility to decode only one of the frames in a DICOM object.
dicom-toimagehas also been optimized by using it.