Skip to content

Fix SCP transfer syntax negotiation quirk#417

Merged
Enet4 merged 1 commit intomasterfrom
bug/ul/server-ts-negotiation
Sep 23, 2023
Merged

Fix SCP transfer syntax negotiation quirk#417
Enet4 merged 1 commit intomasterfrom
bug/ul/server-ts-negotiation

Conversation

@Enet4
Copy link
Copy Markdown
Owner

@Enet4 Enet4 commented Sep 23, 2023

This fixes a quirk in dicom_ul that I found while working on #408. Affects the behavior of dicom-storescp so that --uncompressed-only actually functions as originally intended.

Summary

  • Only accept all transfer syntaxes supported by the central transfer syntax registry if no transfer syntaxes were explicitly added via with_transfer_syntax
  • add test that covers selecting a transfer syntax other than the first one proposed by the SCU.

- only accept all supported TSes
  if no TSes were explicitly added
  via `with_transfer_syntax`
- add test that covers selecting
  a TS other than the first one proposed by the SCU
@Enet4 Enet4 added bug This is a bug A-lib Area: library C-ul Crate: dicom-ul labels Sep 23, 2023
@Enet4 Enet4 merged commit 354fb06 into master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library bug This is a bug C-ul Crate: dicom-ul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant