Conversation
- do not throw error on missing Number of Frames, interpret instead as having a single frame
- change end of frames check to next even - bail out earlier if there are very few bytes left - add frame number being decoded on error - adjust comments, leave notes
- extend frame data retrieval logic to consider frames spanning multiple fragments - include equivalent end-of-file and SOI marker checks from JpegAdapter::decode
Owner
Author
|
Indeed I found issues in |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #413, so that it can decode JPEG baseline with odd length fragments.
An alternative to trying to patch the
decodeimplementation is to remove it entirely and let the trait's default implementation anddecode_frametake its place.