-
Notifications
You must be signed in to change notification settings - Fork 113
Can't set_transfer_syntax in some cases #409
Copy link
Copy link
Closed
Labels
A-libArea: libraryArea: libraryC-objectCrate: dicom-objectCrate: dicom-objectbreaking changeHint that this may require a major version bump on releaseHint that this may require a major version bump on releasebugThis is a bugThis is a bug
Description
This code won't work in v0.6:
obj.meta_mut().set_transfer_syntax(&dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN);This is because the setter is only generic over 2 of the 3 type parameters in TransferSyntax (they were redesigned in #361).
The user needs to type-erase the transfer syntax explicitly.
obj.meta_mut().set_transfer_syntax(&dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN.erased());Unfortunately, it is considered a breaking change to update this now, considering that there may be method calls with a turbo fish to specify these type parameters.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-libArea: libraryArea: libraryC-objectCrate: dicom-objectCrate: dicom-objectbreaking changeHint that this may require a major version bump on releaseHint that this may require a major version bump on releasebugThis is a bugThis is a bug