Skip to content

Feat 100 hz ppg#8

Merged
nitin710 merged 7 commits intomasterfrom
feat-100HzPPG
Mar 30, 2023
Merged

Feat 100 hz ppg#8
nitin710 merged 7 commits intomasterfrom
feat-100HzPPG

Conversation

@nitin710
Copy link
Collaborator

@nitin710 nitin710 commented Mar 9, 2023

Description

  • CheckForBeat() function is modified
    • Now, you can choose to skip the DC estimator inside the checkForBeat function and use a simple IIR HPF in the calling function. For us, it is processHeartRate in EmotiBit.cpp
    • The low pass filter, before peak detection, has been changed to IIR filter
  • This change should support filtering for signals sampled at frequencies other than 25Hz.

Breaking changes

  • This PR modifies the CheckForBeat() function call.
  • You will also need an additional library, linked in the requirements below

Requirements

Proposed future edits

Issues Referenced

  • Fixes # (issue)

Copy link

@produceconsumerobot produceconsumerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 01

@nitin710 nitin710 merged commit 8f0b550 into master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants