Skip to content

Update LEDS#326

Merged
Joseph-Jacobson merged 12 commits into1.12.1.feat-blePrototype-Examplefrom
master
May 7, 2025
Merged

Update LEDS#326
Joseph-Jacobson merged 12 commits into1.12.1.feat-blePrototype-Examplefrom
master

Conversation

@Joseph-Jacobson
Copy link
Contributor

@Joseph-Jacobson Joseph-Jacobson commented May 7, 2025

Description

Requirements

Issues Referenced

  • Fixes # (issue)

Documentation update

Link to a change in documentation (if any)

Notes for Reviewer

  • Add detailed notes explaining code changes, algorithms or any other information that can help the reviewer understand the PR better.

List of new distributable files (For software PR only)

  • Name all new files added with this PR that need to be distributed with the release package. This includes files like .json, .xml settings files etc.

Testing

Results

  • Synopsis of results, details if required.

Feature Tests

Shared files

  • Firmware binary: [Link to firmware binary]
  • Other files.

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Get approval from the reviewer
    • Passed testing on Windows
    • Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Update software bundle version in ofxEmotiBitVersion.h
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • doxygen style comments included for new code snippets
  • Required documentation updated

Screenshots:

@Joseph-Jacobson Joseph-Jacobson merged commit 8a055f2 into 1.12.1.feat-blePrototype-Example May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants