Conversation
…ass to call FileTransferManager
pulling latest FileTransfer into EmotiBitEda fix
Pulling latest feat_fileTransfer
produceconsumerobot
requested changes
Mar 14, 2024
Collaborator
produceconsumerobot
left a comment
There was a problem hiding this comment.
@nitin710 review complete
EmotiBit.cpp
Outdated
| timerStop(timer); | ||
| // turn OFF leds | ||
| // ToDo: Move this out of the #ifdef block. This behavior should be consistant across all Feathers. | ||
| led.setLED(uint8_t(EmotiBit::Led::RED), false); |
Collaborator
There was a problem hiding this comment.
Should FTP mode turn ON all the LEDs?
Maybe it indicates "things are happs!"?
Collaborator
Author
There was a problem hiding this comment.
We should discuss the UX.
merge emotibit_eda into FileTransfer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requirements
Issues Referenced
Documentation update
Notes for Reviewer
Testing
Results
Feature Tests
Shared files
Checklist to allow merge
masterDIGITAL_WRITE_DEBUG= false (if set true while testing)Screenshots: