Skip to content

Fix improve hr#268

Merged
nitin710 merged 7 commits intomasterfrom
fix-improveHr
Apr 13, 2023
Merged

Fix improve hr#268
nitin710 merged 7 commits intomasterfrom
fix-improveHr

Conversation

@nitin710
Copy link
Collaborator

@nitin710 nitin710 commented Apr 12, 2023

Description

  • Fixes to improve Heart rate.
  • All changes live in the linked PR.
  • This PR only contains a version bump in the main FW repo.

Requirements

Issues Referenced

Documentation update

  • None

Notes for Reviewer

  • None

Testing

List of conditions to be tested

  • Complete algorithm design and testing can be found in the Heartbeat Det AC Filter Calculator sheet

Results

  • Check Heartbeat Det AC Filter Calculator sheet

Shared files

  • Check the linked PR

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • doxygen style comments included for new code snippets
  • Required documentation updated

Screenshots:

@nitin710 nitin710 merged commit 9705ef7 into master Apr 13, 2023
@nitin710 nitin710 deleted the fix-improveHr branch April 13, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant