Skip to content

Latest commit

 

History

History
66 lines (52 loc) · 3.05 KB

File metadata and controls

66 lines (52 loc) · 3.05 KB

Description

Requirements

  • [PR name](Link to PR)

Issues Referenced

  • Fixes # (issue)

Documentation update

Link to a change in documentation (if any)

Notes for Reviewer

  • Add detailed notes explaining code changes, algorithms or any other information that can help the reviewer understand the PR better.

Testing

Feature Tests (Integration tests)

Feature Test Result
Feature test 1 ✔️ or ✖️

Unit Tests

Unit Test Result
Feature test 1 ✔️ or ✖️

Shared files

  • Firmware binary: [Link to firmware binary]
  • Other files.

List of new distributable files (For software PR only)

  • Name all new files added with this PR that need to be distributed with the release package. This includes files like .json, .xml settings files etc.

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Get approval from the reviewer
    • Passed testing on Windows
    • Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Update software bundle version in ofxEmotiBitVersion.h
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • doxygen style comments included for new code snippets
  • Required documentation updated

Screenshots: