Commit 3e0071f
committed
workflow/semver-auto: rebase PR
When testing if a PR is API backward compatible or not, we need to test
against the base branch, not the head against the PR branched is based
on.
Otherwise it can lead to the case where a breaking change was merged
after that a PR was proposed, go-apidiff will fail because it'll test
the repo against base_ref.
The PR needs to be rebased on base_ref so the actual compatibility can be
verified.
If the PR can't be rebase for any reason, we'll return a failure and add
the label `semver:unknown`.1 parent a6cf357 commit 3e0071f
2 files changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
| |||
23 | 34 | | |
24 | 35 | | |
25 | 36 | | |
| 37 | + | |
26 | 38 | | |
27 | 39 | | |
28 | 40 | | |
| |||
0 commit comments